fix(automerge): implement exponential backoff #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oded-B
reviewed
May 23, 2024
Oded-B
reviewed
May 23, 2024
Oded-B
reviewed
May 23, 2024
Ben10k
commented
May 23, 2024
| @@ -711,7 +738,7 @@ func createCommit(ghPrClientDetails GhPrClientDetails, treeEntries []*github.Tre | |||
| Tree: tree, | |||
| } | |||
|
|
|||
| commit, resp, err := ghPrClientDetails.GhClientPair.v3Client.Git.CreateCommit(ghPrClientDetails.Ctx, ghPrClientDetails.Owner, ghPrClientDetails.Repo, newCommitConfig) | |||
| commit, resp, err := ghPrClientDetails.GhClientPair.v3Client.Git.CreateCommit(ghPrClientDetails.Ctx, ghPrClientDetails.Owner, ghPrClientDetails.Repo, newCommitConfig, nil) | |||
There was a problem hiding this comment.
CreateCommit's signature has changed since GH client v52 that requires an additional parameter for CreateCommitOptions which is used for signing commits
|
I'll fix the linting error, most likely tomorrow. |
|
Yeah, the docker build is unrelated. |
|
@Oded-B linting issues fixed, can you approve workflows and tale a look? |
Oded-B
approved these changes
May 24, 2024
Oded-B
referenced
this pull request
in commercetools/telefonistka
Jun 12, 2024
* Add pagination to "List files in PR" api call (#174) * Support pagination for "List files in PR" API call +relevant test * Update golangci/golangci-lint-action action to v6 (#170) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update GitHub Actions (#144) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update module github.com/google/go-github/v53 to v62 (#173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update all non-major dependencies (#136) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(automerge): implement exponential backoff (#181) * fix(automerge): implement exponential backoff * Update internal/pkg/githubapi/github.go * Fix > 250 char Branch name issue (#188) * Fix > 250 char Branch name issue Move branch name generation to a function. Limit original branch substing to 200 charts Switch target paths substring to sha1 of the target paths. Tests * Address issues raised in PR review: Rename a var Used Repeat to avoid hardcoding long string Made some test input **a bit** more realistic * Cleanup some conflict marker and add comment * Fix some merge bug --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Benas Taurosevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Retry mechanism with exponential backoff is implemented for automatically merging PRs.
Resolves #176
Type of Change
Checklist